Change "rejected" to "changes requested" in 3rd party PR review notification #34481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
May 15, 2025
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
May 16, 2025
GiteaBot
added
lgtm/done
techknowlogick
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 19, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix edithook api can not update package, status and workflow_job events (go-gitea#34495) Fix url validation in webhook add/edit API (go-gitea#34492) Add R-HNF to the TRANSLATORS file (go-gitea#34494) Add missing setting load in dump-repo command (go-gitea#34479) nix flake update (go-gitea#34476) Fix get / delete runner to use consistent http 404 and 500 status (go-gitea#34480) Change "rejected" to "changes requested" in 3rd party PR review notification (go-gitea#34481) Add migrations tests (go-gitea#34456) Fix project board view (go-gitea#34470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes 3rd party notifications wording on a PR review that requests changes and can be considered a follow up for #5858 to also fix #5857 in 3rd party notifications.
The difference in the actual notification would be the following:
While this is a simple string change at first look, it has a deeper UX meaning.
Motivation
We could observe that some developers are hesitant to press the "Request changes" button since their peers first see that their changes were rejected, thus a more appropriate wording that also falls in line with the meaning and UI would be beneficial.
Meaning
Pressing the
Request changesbutton in a PR review means that as a reviewer you are willing to merge the general change in a PR if changes requested review comments are implemented.Rejecting a PR on the other hand would be equivalent with closing it since that change isn't welcome at all (e.g. out of scope feature).
Sync with UI
The UI button says
request changesand the other optionsConsidered Problems
This might break some automation for users who rely on string matching.