Skip to content

Fix edithook api can not update package, status and workflow_job events #34495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristopherHX
Copy link
Contributor

  • the origin of this problem is duplicated code

* the origin of this problem is duplicated code
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 17, 2025
@ChristopherHX ChristopherHX added the backport/v1.24 This PR should be backported to Gitea 1.24 label May 17, 2025
@ChristopherHX
Copy link
Contributor Author

Except workflow_job, this bug affects 1.23 and below starting with the packaging feature

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 18, 2025
@lunny lunny merged commit d89eed9 into go-gitea:main May 18, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone May 18, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 18, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 19, 2025
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 19, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 19, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix edithook api can not update package, status and workflow_job events (go-gitea#34495)
  Fix url validation in webhook add/edit API (go-gitea#34492)
  Add R-HNF to the TRANSLATORS file (go-gitea#34494)
  Add missing setting load in dump-repo command (go-gitea#34479)
  nix flake update (go-gitea#34476)
  Fix get / delete runner to use consistent http 404 and 500 status (go-gitea#34480)
  Change "rejected" to "changes requested" in 3rd party PR review notification (go-gitea#34481)
  Add migrations tests (go-gitea#34456)
  Fix project board view (go-gitea#34470)
lunny pushed a commit that referenced this pull request May 19, 2025
…ts (#34495) (#34499)

Backport #34495 by @ChristopherHX

* the origin of this problem is duplicated code

Co-authored-by: ChristopherHX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants