-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
fix: improve actions status icons and texts #37206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
6e35de7
Rework actions status icons
silverwind 9e266a6
Use "In progress" for StatusRunning description
silverwind 6716fca
Move action-status enrichment off the CommitStatus model
silverwind 1489ee0
Merge branch 'main' into acticons
silverwind c140daf
Shorten doc comments on CommitStatusActionInfo
silverwind 20c0ef8
Move commit_status template into icons/
silverwind 7c310e8
Fix cancelled icon and align action status UI with GitHub
silverwind 92e8974
Use maps.Copy for CommitStatusActionInfo merge
silverwind 1f03083
Merge remote-tracking branch 'origin/main' into acticons
silverwind f67c18f
Keep CanRead/HideActionsURL blocks at callsites
silverwind 264861b
Cover the commit-status tippy tooltip for in-flight action jobs
silverwind 5b83e49
Move action-status enrichment into a template-side lookup
silverwind e70ecdb
Move enrichment helper into its natural home
silverwind b0a485b
Tighten statusinfo package and template hook
silverwind 6cb3859
Move artifact-V4 download helpers into services/actions
silverwind d6cd40b
Collapse statusinfo subpackage into modules/actions
silverwind e9bb781
Merge remote-tracking branch 'origin/main' into acticons
silverwind c76ed0f
Simplify action-status lookup in pulls/status.tmpl
silverwind 561e690
Use maps.Keys for jobIDs collection
silverwind 59715a1
Address PR review feedback
silverwind bc99d63
Rename IconVariant to IconSuffix, drop ternary branching
silverwind 266f9bf
Merge branch 'main' into acticons
silverwind e4dc0c4
Merge branch 'main' into acticons
silverwind 95d29a7
Update templates/repo/icons/action_status.tmpl
wxiaoguang eddeb3f
Merge remote-tracking branch 'origin/main' into acticons
silverwind e83604f
Compute ActionInfo inside status_items.tmpl
silverwind 887b405
Compute ActionInfo only in the merge box, trim comments
silverwind e18443f
Replace integration test with focused unit test
silverwind 8d80fac
Pass icon-suffix to ActionRunStatus in attempt dropdown
silverwind e1730a8
icon variant
wxiaoguang cdfaee6
clean up ActionInfo
wxiaoguang 2035df6
remove ActionsUtils
wxiaoguang 7ea4e6e
fix test
wxiaoguang adf0206
fix
wxiaoguang 9d39052
Apply suggestion from @silverwind
silverwind e8ccdff
Apply suggestion from @silverwind
silverwind ca1428d
Merge branch 'main' into acticons
bircni 890af6c
Rename ActionRunStatus to ActionStatusIcon and ActionsRunStatus to Ac…
silverwind dfb38d7
Use plain quotes in ActionStatusIcon
silverwind 9cec488
Revert unrelated pnpm-workspace.yaml drift
silverwind 221c66c
Merge branch 'main' into acticons
silverwind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.