Add search bar for organization members tab page#37347
Open
lunny wants to merge 7 commits intogo-gitea:mainfrom
Open
Add search bar for organization members tab page#37347lunny wants to merge 7 commits intogo-gitea:mainfrom
lunny wants to merge 7 commits intogo-gitea:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds member search functionality to the Organization Settings → Members page (resolving #37072) by wiring a q query parameter from the UI through the web router into the org-member lookup logic.
Changes:
- Add a search bar and “shown / total” member count display to the members template, including a “no results” empty state.
- Extend org member lookup options to support keyword filtering (username/full name/email with privacy rules) and persist query params through pagination.
- Add model-level tests covering member search behavior (including private email visibility rules).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
templates/org/member/members.tmpl |
Adds search input + count display and a no-results state for the members list. |
routers/web/org/members.go |
Reads q, passes it into member queries, and persists query params in pagination. |
models/organization/org.go |
Adds keyword/email search filtering to org member queries via a user join. |
models/organization/org_test.go |
Adds tests validating org member search results and email privacy behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lunny Xiao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #37072