Skip to content

enhance: Adjust Workflow Graph styling#37497

Merged
bircni merged 33 commits into
go-gitea:mainfrom
bircni:readjust-workflows
Jun 7, 2026
Merged

enhance: Adjust Workflow Graph styling#37497
bircni merged 33 commits into
go-gitea:mainfrom
bircni:readjust-workflows

Conversation

@bircni

@bircni bircni commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Screenshot

Fixes #37493
Fixes #37395

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2026
@wxiaoguang

wxiaoguang commented May 1, 2026

Copy link
Copy Markdown
Contributor

Also this one? The workflow summary is not intuitive. #37395

@bircni

bircni commented May 1, 2026

Copy link
Copy Markdown
Member Author

Also this one? The workflow summary is not intuitive. #37395

yes on it

@bircni bircni requested a review from wxiaoguang May 1, 2026 10:38
@bircni bircni marked this pull request as ready for review May 1, 2026 10:38
@wxiaoguang

wxiaoguang commented May 1, 2026

Copy link
Copy Markdown
Contributor

Maybe the curves can be adjusted to avoid unnecessary cross points or ambiguous linked steps.

image

wxiaoguang
wxiaoguang reviewed May 1, 2026
View reviewed changes
Comment thread templates/devtest/repo-action-view.tmpl Outdated
@bircni

bircni commented May 1, 2026

Copy link
Copy Markdown
Member Author

this might extend into a larger refactor - found some other problems

@bircni bircni marked this pull request as draft May 1, 2026 12:22
@bircni

bircni commented May 1, 2026

Copy link
Copy Markdown
Member Author

@wxiaoguang what do you think?

@wxiaoguang

wxiaoguang commented May 1, 2026

Copy link
Copy Markdown
Contributor

@wxiaoguang what do you think?

UI looks clearer than before.

@bircni

bircni commented May 1, 2026

Copy link
Copy Markdown
Member Author

@wxiaoguang what do you think?

UI looks clearer than before.

if you can help simplifying or improving code structure would be great :)

@wxiaoguang

wxiaoguang commented May 1, 2026

Copy link
Copy Markdown
Contributor

@wxiaoguang what do you think?

UI looks clearer than before.

if you can help simplifying or improving code structure would be great :)

Let's make sure (almost) everyone likes the new UI first

@wxiaoguang wxiaoguang marked this pull request as ready for review May 1, 2026 15:52
wxiaoguang
wxiaoguang previously approved these changes May 2, 2026
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2026
@lunny lunny added type/bug backport/v1.26 This PR should be backported to Gitea 1.26 labels May 2, 2026
@lunny

lunny commented May 2, 2026

Copy link
Copy Markdown
Member

It seems there are still some bugs.

image

@bircni

bircni commented May 2, 2026

Copy link
Copy Markdown
Member Author

It seems there are still some bugs.

how to reproduce?

@lunny

lunny commented May 2, 2026

Copy link
Copy Markdown
Member

It seems there are still some bugs.

how to reproduce?

Use the workflows from #36248 (comment)

@wxiaoguang wxiaoguang removed the backport/v1.26 This PR should be backported to Gitea 1.26 label May 3, 2026
bircni added 6 commits May 3, 2026 10:32
@bircni
Fix Actions workflow graph overflow and job duration layout
589830c 
Make the workflow dependency graph container scrollable so wide DAGs aren’t clipped.
Improve the jobs list layout by keeping durations fixed-width/right-aligned so long times don’t squeeze job names.
Add a devtest WideDAG run to reproduce overflow and long-duration cases.
@bircni
more intuitive
168bccc
@bircni
part 1
0f5f47a
@bircni
testing part
02944c3
@bircni
2
57ac717
@bircni
3
edfa813
@bircni

bircni commented May 3, 2026

Copy link
Copy Markdown
Member Author
image @lunny fixed

@github-actions github-actions Bot added type/enhancement An improvement of existing functionality and removed type/bug labels May 31, 2026
@bircni bircni requested review from lunny and silverwind May 31, 2026 16:44
@bircni bircni mentioned this pull request May 31, 2026
Open
24 tasks
@lunny

lunny commented Jun 3, 2026

Copy link
Copy Markdown
Member

Since #37478 merged, we might need to consider reusable workflows? It's not a block for this PR, it could also be another PR.

image

@bircni

bircni commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Since #37478 merged, we might need to consider reusable workflows? It's not a block for this PR, it could also be another PR.

you are right :/

@lunny

lunny commented Jun 5, 2026

Copy link
Copy Markdown
Member

And whether there is a potential conflict between this and #36564

@bircni

bircni commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

And whether there is a potential conflict between this and #36564

the other PR needs to adopt the changes then...

@bircni

bircni commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Since #37478 merged, we might need to consider reusable workflows? It's not a block for this PR, it could also be another PR.

They should just not show up in the graph, GitHub is doing the same there...
See example here: https://github.com/bircni/test-workflows2/actions/runs/27032767185

@bircni bircni mentioned this pull request Jun 5, 2026
Open
8 tasks
@bircni

bircni commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Adjusted it to match githubs style @lunny

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2026
@lunny lunny requested a review from Zettat123 June 5, 2026 19:03
@Zettat123

Zettat123 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

GitHub actually displays reusable workflows in the graph, but it doesn't show the hierarchy. For multi-level nested reusable workflows, the graph fails to fully display the nesting depth (it only shows up in the tooltip). See this example: https://github.com/Zettat123/test-workflow-reusable/actions/runs/27082666460

image

In fact, I think GitHub's workflow graph layout isn't ideal and we should be able to optimize it. However, I'm not sure what a better solution looks like right now. I believe we can continue refining how reusable workflows are displayed in future PRs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2026
@bircni bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 7, 2026
@bircni bircni enabled auto-merge (squash) June 7, 2026 15:46
@bircni bircni merged commit 1c289df into go-gitea:main Jun 7, 2026
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 7, 2026
@bircni bircni deleted the readjust-workflows branch June 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lunny lunny lunny approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind Awaiting requested review from silverwind

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

Workflow Dependencies graph can become unreadable / inaccessible when content overflows the container The workflow summary is not intuitive.

8 participants

@bircni @wxiaoguang @lunny @lutinglt @silverwind @Zettat123 @GiteaBot