fix(file-tree): handle submodule links and missing view container#38033
Open
yszl666 wants to merge 1 commit into
Open
fix(file-tree): handle submodule links and missing view container#38033yszl666 wants to merge 1 commit into
yszl666 wants to merge 1 commit into
Conversation
Prevent tree view navigation from intercepting submodule entries so the browser can follow external repository links normally. Also guard against a missing `.repo-view-content` container before updating partial page content to avoid runtime errors.
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Jun 8, 2026
| const response = await GET(u.href); | ||
| const elViewContent = document.querySelector('.repo-view-content')!; | ||
| const elViewContent = document.querySelector('.repo-view-content'); | ||
| if (!elViewContent) return; |
Contributor
There was a problem hiding this comment.
It must exist, otherwise the related bug should be fixed.
So please use the old approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent tree view navigation from intercepting submodule entries so the browser can follow external repository links normally.
Also guard against a missing
.repo-view-contentcontainer before updating partial page content to avoid runtime errors.