fix(gen): handle error from MarkFlagRequired("input") via cobra.CheckErr #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Handle the previously unhandled error from the Cobra required flag setup. Wrap
cmd.MarkFlagRequired("input")withcobra.CheckErr(...)ininternal/gen/gen.goso setup failures print usage and exit non‑zero.User Case Description
ensuring misconfiguration is caught.
Handle
MarkFlagRequired("input")Error withcobra.CheckErrReplaces the direct call to
cmd.MarkFlagRequired("input")withcobra.CheckErr(cmd.MarkFlagRequired("input"))ininternal/gen/gen.go. This ensures any failure during flag-setup is surfaced to users and the CLI exits with a non-zero status.Key Changes
• Wrapped
cmd.MarkFlagRequired("input")withcobra.CheckErr(...)Affected Areas
•
internal/gen/gen.go(CLI flag initialization for thegencommand)This summary was automatically generated by @propel-code-bot