fix: fix generation of DAO objects with cycles #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloyd-juicelabs
force-pushed
the
fix-dao-generation-with-cycles
branch
from
85b4d14 to
35b36f5
Compare
tr1v3r
changed the title
lloyd-juicelabs
force-pushed
the
fix-dao-generation-with-cycles
branch
from
35b36f5 to
1b23dc0
Compare
lloyd-juicelabs
force-pushed
the
fix-dao-generation-with-cycles
branch
from
1b23dc0 to
e834ed4
Compare
3 tasks
tr1v3r
reviewed
Apr 16, 2025
| for i, relationship := range relationships { | ||
| varType := strings.TrimLeft(relationship.Field.FieldType.String(), "[]*") | ||
| cached := cache[varType] | ||
| result[i] = *field.NewRelationWithType(field.RelationshipType(relationship.Type), relationship.Name, varType, cached...) |
There was a problem hiding this comment.
why rebuild a new relation type here?
There was a problem hiding this comment.
As far as I can tell this is needed as the cache just has the childRelations? I thought this is what the old code was doing, but the childRelations were just missing.
You have a better idea of how this should work though, so feel free to suggest something better or change my branch, my understanding is very surface level.
There was a problem hiding this comment.
Why does the implementation use a separate loop for assigning values to result[i] instead of performing the assignment within the initial loop, as seen in the original implementation? What are the technical considerations behind this design choice?
|
Duplicate of #1270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
When generating models that are recursive, the current pullRelationships method will incorrectly provide an empty result if the type is already in the cache.
This change alters the generator so it walks the tree twice, once to locate all the types and then a second time to actually generate all the code once the cache is correctly populated with all the types.
I have provided a test case ensure generation is working correctly.
fix #1242
User Case Description
Full bug description here: #1242