fix: fix generation of DAO objects with cycles #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
When generating models that are recursive, the current pullRelationships method will incorrectly provide an empty result if the type is already in the cache.
This change alters the generator so it walks the tree twice, once to locate all the types and then a second time to actually generate all the code once the cache is correctly populated with all the types.
I have provided a test case ensure generation is working correctly.
fix #1242
User Case Description
Full bug description here: #1242