Skip to content

Conversation

@martialblog
Copy link
Contributor

@martialblog martialblog commented Jun 20, 2025

Hi,

I ran into some issues while working with the metrics/expand endpoint. This PR addresses this issues.

This should conclude the issue #245

  1. The JSON format was not selected by default.

The treejsonFormat was used as the default if none was given, but it was missing as a valid format in the ValidExpandFormat helper.

#Before
curl "http://localhost:8081/metrics/expand?query=node1.value"
unsupported format:

# With the PR
curl "http://localhost:8081/metrics/expand?query=node1.value"
{"results":["node1.value"]}
  1. It had the parameters "tz", "from", and "until", which are not described in the Graphite API

I assume this was just a copy-paste artifact from the findHandler, not sure. I removed these parameters.

Regards,
Markus

@Civil Civil enabled auto-merge June 20, 2025 09:45
@Civil Civil added this pull request to the merge queue Jun 20, 2025
Merged via the queue into go-graphite:main with commit 3ff3820 Jun 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants