Make cache size 64 bit

[deniszh]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @deniszh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the cache's capacity by transitioning its internal size management from 32-bit to 64-bit integers. This fundamental change allows the cache to support and track significantly larger data volumes, improving its scalability and robustness for high-demand scenarios.

Highlights

• Cache Size Capacity Increase: The maximum cache size and the current cache size tracking have been upgraded from 32-bit to 64-bit integers, allowing for significantly larger cache capacities.
• API and Internal Type Updates: Relevant fields, method signatures (e.g., SetMaxSize, Size), and atomic operations (e.g., atomic.AddInt32, atomic.LoadInt32) have been updated to use 64-bit integer types (int64, uint64) to accommodate the increased size.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the cache size representation from 32-bit to 64-bit integers, allowing for cache sizes exceeding previous limits. The modifications in cache/cache.go and carbon/config.go are consistent, changing field types from int32/uint32 to int64/uint64 and updating the corresponding atomic operations and function signatures.

While the changes in the modified files are correct, there are a couple of critical issues in other files that need to be addressed to ensure the project compiles and runs correctly:

1. Compilation Error in Test: In cache/dump_test.go on line 24, the call to c.SetMaxSize still uses uint32 which will cause a compilation failure. It should be updated to c.SetMaxSize(uint64(pointsCount*metrics + 1)).
2. Potential Logging Bug: In carbon/grace.go on line 97, app.Cache.Size() now returns an int64, but it's being cast to int for logging with zap.Int. This can cause an integer overflow and incorrect logging on 32-bit systems. It should be changed to use zap.Int64("records", cacheSize).