Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the Makefile by removing dynamic Go version detection and stable version checks, and statically defining the GOEXPERIMENT variable. Feedback suggests using conditional assignment (?=) instead of immediate assignment (:=) for GOEXPERIMENT to allow developers and CI environments to override it.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #61 +/- ##
=====================================
Coverage 85.2% 85.2%
=====================================
Files 27 27
Lines 6135 6135
=====================================
Hits 5230 5230
Misses 905 905
|
GO_STABLE_VERSION shelled out to go.dev on every make invocation, so any target failed or silently changed the experiment set whenever the network was unavailable or the release feed moved on. Pin the list to simd and runtimesecret, which both the local toolchain and the CI runners accept, and drop the now unused GO_VERSION probe.
actions/checkout, actions/setup-go and codecov/codecov-action have all released v7; github/codeql-action stays on v4 because that is still its latest major. The v7 releases are ESM repackaging plus, for checkout, a new block on checking out fork pull requests under pull_request_target and workflow_run. Neither event is used here, so behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent build/CI fixes.
make: pinGOEXPERIMENTwithout probing the Go release feedGO_STABLE_VERSIONshelled out tohttps://go.dev/dl/?mode=jsonon everymakeinvocation, so any target failed (or silently changed the experimentset) whenever the network was unavailable or the release feed moved on. The
experiment list is now pinned to
simd,runtimesecret, which both the localtoolchain and the CI runners accept, and the unused
GO_VERSIONprobe isdropped.
CI: bump GitHub Actions to their current major releases
actions/checkout,actions/setup-goandcodecov/codecov-actionare movedfrom v6 to v7.
github/codeql-actionstays on v4 because that is still itslatest major.
The v7 releases are ESM repackaging plus, for
checkout, a new block onchecking out fork pull requests under
pull_request_targetandworkflow_run.Neither event is used in this repository, so behaviour is unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_016EWrxxf4HKDErJgYop4wHd