Allow users to specify a custom NTLM negotiator #544
Merged
+57
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpt-erikgeiser
force-pushed
the
custom_ntlm_negotiator
branch
from
08f462d to
d2cec15
Compare
cpuschma
requested changes
Jan 9, 2025
Member
cpuschma
left a comment
cpuschma
left a comment
There was a problem hiding this comment.
Thank you for your idea to allow to use a custom negotiator! LGTM so far besides two points regarding the error message.
Contributor
Author
|
Thanks for the fast review, I implemented your suggestions. |
cpuschma
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Negotiatorfield toNTLMBindRequestwhich lets users specify a custom NTLM implementation. This is needed becausegithub.com/Azure/go-ntlmsspis a very limited NTLM implementation with no support for features such as channel binding which may be required to connect to AD LDAP.