fix(conn): parse ldapi:// URLs per RFC 4516#590
Merged
Conversation
The unix socket path for ldapi:// belongs in the host component, percent-encoded; the path component is reserved for a DN. net/url rejects %2F-encoded hosts as invalid, so DialURL never accepted the spec-compliant ldapi://%2Fvar%2Frun%2Fldapi form and silently fell through to /var/run/slapd/ldapi instead. Add a thin parseLDAPURL that pre-extracts and decodes the host for the ldapi scheme, then defers to net/url for everything else. The older ldapi:///path form still works. Closes go-ldap#564. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unix socket path for `ldapi://` belongs in the host component, percent-encoded; the path is reserved for a DN. `net/url` rejects `%2F`-encoded hosts as invalid, so `DialURL` never accepted the spec-compliant `ldapi://%2Fvar%2Frun%2Fldapi` form and silently dropped through to `/var/run/slapd/ldapi` instead.
Added a small `parseLDAPURL` that splits and decodes the host for the `ldapi` scheme, then defers to `net/url` for everything else. The legacy `ldapi:///path` form still works.
This is a focused fix for the socket-path parsing; DN handling (using the path component as a default SearchBase, per cpuschma's comment on the issue) is left as a separate change.
Closes #564.