strip surrounding spaces before hexstring form in DN value - #606
Open
netliomax25-code wants to merge 1 commit into
Open
strip surrounding spaces before hexstring form in DN value#606netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Contributor
Author
|
gentle ping |
Member
|
@netliomax25-code Thank you for your pull requests. I will take a look, but please note that we review and compare the proposed changes to the LDAP specification and the project guidelines in our free time, and we currently have a high number of pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#and hex-decodes it before any space stripping, but the string form is stripped of insignificant leading and trailing spaces by decodeString.O= #04024869is read as the literal string#04024869andO=#04024869is rejected, while the canonicalO=#04024869decodes to the BER valueHi.Strip the surrounding spaces before detecting and decoding the hexstring form, matching the string form and the existing
CN = ...handling already covered in the parse tests. Added parse cases for the leading, trailing, and both-sides forms.