fix: avoid out-of-range index for serverSaslCreds in saslBindTokenExchange - #609
Open
netliomax25-code wants to merge 2 commits into
Open
fix: avoid out-of-range index for serverSaslCreds in saslBindTokenExchange#609netliomax25-code wants to merge 2 commits into
netliomax25-code wants to merge 2 commits into
Conversation
netliomax25-code
force-pushed
the
sasl-bind-creds-bounds
branch
from
July 5, 2026 14:03
fd1055d to
9d62ce7
Compare
Contributor
Author
|
pushed a fix for the lint failure. errcheck flagged the deferred Close calls in the new test, and the branch also needed a rebase onto master so the linter stopped attributing pre-existing lines to this diff. checks are green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require at least four children before reading the creds child, so a short response falls through to GetLDAPError instead of indexing past the slice. Added a regression test that drives the exchange with a three-child in-progress response.