mysql时间字符串(varchar "2018-11-20 10:10:10")支持转为ES的date类型#305
Open
tiankonghewo wants to merge 13 commits intogo-mysql-org:masterfrom
Open
mysql时间字符串(varchar "2018-11-20 10:10:10")支持转为ES的date类型#305tiankonghewo wants to merge 13 commits intogo-mysql-org:masterfrom
tiankonghewo wants to merge 13 commits intogo-mysql-org:masterfrom
Conversation
siddontang
reviewed
Nov 20, 2018
|
|
||
| + MySQL 8 | ||
| + ES 6 | ||
| + ES 6 (After verification (version 6.4.2), it is now supported. Delete and update are supported) |
Collaborator
There was a problem hiding this comment.
Em, are you sure we can support ES 6 directly? Seem ES 6 has already removed doc Type?
siddontang
reviewed
Nov 20, 2018
| if col.Type == schema.TYPE_STRING { | ||
| col.Type = schema.TYPE_DATETIME | ||
| v := r.makeReqColumnData(col, value) | ||
| str, _ := v.(string) |
Collaborator
There was a problem hiding this comment.
switch v.(type) {
case string:
case []byte:
default:
}I think you can check string and []byte here.
siddontang
reviewed
Nov 20, 2018
river/sync.go
Outdated
| case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: | ||
| fieldValue = r.makeReqColumnData(col, time.Unix(v.Int(), 0).Format(mysql.TimeFormat)) | ||
| } | ||
| } else { |
Collaborator
There was a problem hiding this comment.
please use else if col.Type == schema.TYPE_STRING
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.