-
Notifications
You must be signed in to change notification settings - Fork 1k
Update CI #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #1034
Conversation
dveeden
commented
May 6, 2025
•
edited
Loading
edited
- Add ubuntu-latest
- Add MySQL 9.x innovation release
- Remove Go 1.22
- Update MySQL 8.0 and 8.4 versions
6eb50bc
to
d35fa16
Compare
e93fcb7
to
95f592b
Compare
I wanted to add tests with MariaDB, but wasn't able to get a service container with MariaDB running with binlogs enabled.
|
29494b1
to
95f592b
Compare
I also tried this: commit 29494b1aea4fd29e4e8d1cab179a67641913e10a (HEAD -> update_ci_2025_may, origin/update_ci_2025_may)
Author: Daniël van Eeden <[email protected]>
Date: Wed May 7 09:30:18 2025 +0200
Enable disabled tests
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index af153ff..06abb21 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -88,9 +88,9 @@ jobs:
- name: Run tests
run: |
# separate test to avoid RESET MASTER conflict
- # TODO: Fix "dump/" and "canal/": mysqldump tries to run SHOW MASTER STATUS on v8.4.0
go test $(go list ./... | grep -v canal | grep -v dump)
- # go test $(go list ./... | grep canal | grep -v dump)
+ go test $(go list ./... | grep canal)
+ go test $(go list ./... | grep dump)
golangci:
name: golangci But that failed on MySQL 8.4 and 9.x. I'm not sure why. This might be for a different reason that the |
To get MariaDB in PeerDB's CI I had to have a step run docker directly: https://github.com/PeerDB-io/peerdb/blob/84fe9ce286a8c8cc03a6369e4b7ce4b2f7505d1c/.github/workflows/flow.yml#L125 Note maria seems to have MIXED as default binlog format To deal with port conflicts I have maria & mysql tests run separately |
@dveeden After changing CI, you should also adjust "required CI" in the repo setting to align. Do you want me to help you adjust it? |
@lance6716 I might not have the permissions to do that. Also, a required check did not run for this PR, so it can't be merged yet. This is because there is a required check for Go 1.22... which was removed in this PR |