Fix major.minor version resolution in shims when using go.mod#499
Closed
ChronosMasterOfAllTime with Copilot wants to merge 5 commits into
Closed
Fix major.minor version resolution in shims when using go.mod#499ChronosMasterOfAllTime with Copilot wants to merge 5 commits into
ChronosMasterOfAllTime with Copilot wants to merge 5 commits into
Conversation
Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>
Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>
… goenv-version-name Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>
Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with major.minor shims not resolving correctly
Fix major.minor version resolution in shims when using go.mod
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GOENV_GOMOD_VERSION_ENABLE=1is set and go.mod specifies a major.minor version (e.g.,go 1.25), shim execution fails with "command not found" even when the corresponding patch version (e.g.,1.25.4) is installed.Root cause:
goenv-version-nameresolved "1.25" → "1.25.4" internally but never returned the resolved version, leaving shims with no version to execute.Changes
libexec/goenv-version-name
GOENV_GOMOD_VERSION_ENABLEis setversion_existschecklibexec/goenv-which
version_existsimplementation with goenv-version-name (handle both major.minor and major.minor.patch)GOENV_GOMOD_VERSION_ENABLEvariable (was inconsistently usingGOENV_GO_MOD_ENABLE)Tests
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.