V3: Fix doctor system go detection and goenv shimming#532
Merged
Conversation
ChronosMasterOfAllTime
requested review from
reneleonhardt and
syndbg
as code owners
ChronosMasterOfAllTime
changed the title
Instead of relying on PATH (which may not be set up in CI), use runtime.GOROOT() to locate the Go compiler used to run the tests. This is more reliable across different CI environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When system go installed it somehow gets precedence on shims
When running goenv init in a subshell it loses itself