Skip to content

fix(init): Update 'read -ra' to 'read -rA' in zsh fixing invalid option errors #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronosMasterOfAllTime merged 1 commit into from
May 19, 2026
Merged

fix(init): Update 'read -ra' to 'read -rA' in zsh fixing invalid option errors #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cmd/shell/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ func renderInitScript(shell shellutil.ShellType, cfg *config.Config, noRehash bo
// Clean up any version bin directories from PATH (e.g., from venv capture)
builder.WriteString("# Remove any goenv version bin directories from PATH\n")
builder.WriteString("_NEW_PATH=\"\"\n")
builder.WriteString("while IFS=: read -ra PATHARRAY; do\n")
if shell == shellutil.ShellTypeZsh {
builder.WriteString("while IFS=: read -rA PATHARRAY; do\n") // required captial A for zsh read command
} else {
builder.WriteString("while IFS=: read -ra PATHARRAY; do\n")
}
builder.WriteString(" for i in \"${PATHARRAY[@]}\"; do\n")
builder.WriteString(" case \"$i\" in\n")
builder.WriteString(" \"$GOENV_ROOT\"/versions/*/bin) ;;\n")
Expand All @@ -310,7 +314,11 @@ func renderInitScript(shell shellutil.ShellType, cfg *config.Config, noRehash bo
builder.WriteString("unset _NEW_PATH\n")
builder.WriteString("# Remove shims from PATH if present (to re-add in correct position)\n")
builder.WriteString("_NEW_PATH=\"\"\n")
builder.WriteString("while IFS=: read -ra PATHARRAY; do\n")
if shell == shellutil.ShellTypeZsh {
builder.WriteString("while IFS=: read -rA PATHARRAY; do\n") // required captial A for zsh read command
} else {
builder.WriteString("while IFS=: read -ra PATHARRAY; do\n")
}
builder.WriteString(" for i in \"${PATHARRAY[@]}\"; do\n")
builder.WriteString(" case \"$i\" in\n")
builder.WriteString(" \"$GOENV_ROOT\"/shims) ;;\n")
Expand Down
Loading