fix deadlock when batch canceled, some workUnit's done channel can't be closed #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vvnotw wants to merge 1 commit into go-playground:v3 from vvnotw:v3

vvnotw commented Sep 12, 2019

It happend in this situation:

call Batch.Cancel()
wu.cancelling is set in cancelWithError()
wu.writing is set in Queue()
now, wu.done is never closed, batch will wait forever


          fix deadlock when batch canceled, some workUnit's done channel

9aae608

can't be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet