Conversation
| dir := lc.Dir() | ||
|
|
||
| fu := fetchup.New(dir, us...) | ||
| fu := fetchup.New(us...).WithSaveTo(dir) |
Fly-Playgroud
requested review from
Fly-Playgroud and
ysmood
and removed request for
ysmood
|
I noticed this also and found @secustor already submitted a PR. Thank you very much :) |
|
Since the new version of fetchup has been adapted, why not merge it? |
|
@ysmood, could you look into merging this please? It's a pain to keep downgrading fetchup to v0.3.0 every time after |
|
why this, never merge? |
Yet,
Hmm.. do the above mean that @ysmood can merge it now, or there need yet another reviewer? |
Very good question.. why? |
9 participants
This PR updates
github.com/ysmood/fetchupandgithub.com/ysmood/gotto the newest version.As visible in the first commit it bumped the version in go and adapted to changed APIs in
fetchupDevelopment guide
Link
Test on local before making the PR
The simple check script fails for changes outside of this PR so I could not run it outside of the full context.
That being said I can try to fix them, I have some local changes to fix most surface problems.