fix(emr): rename ConfigurationProperties / StepProperties to the SDK Properties member

[go-to-k]

Summary

CFn spells the EMR application-configuration bag
Configuration.ConfigurationProperties and the step bag
HadoopJarStepConfig.StepProperties; both SDK members are named Properties.
The EMR providers cast the CFn blobs straight to the SDK types, and the AWS
SDK v3 serializer drops unknown members — so every EMR application
configuration (spark-defaults / hive-site / yarn-site …) silently vanished and
the cluster came up unconfigured while cdkd reported the deploy as successful.
Step properties were dropped the same way.

Both value shapes already match (Record<string,string> for the former,
KeyValue[] for the latter — verified against the live CFn registry schema on
2026-08-09), so both directions are pure key renames. Note the issue text
predicted a map→list conversion for StepProperties; the live schema shows it
is already a KeyValue array, so no shape change is needed.

What changed

New shared helper src/provisioning/emr-configuration.ts:

• toSdkConfigurations — renames ConfigurationProperties -> Properties at
  every Configurations nesting level (the type nests into itself)
• toSdkStepConfigs — HadoopJarStep.StepProperties -> Properties
• toSdkInstanceTypeConfigs — the per-instance-type nested Configurations

Wired at every forwarding site:

Site	File
top-level Configurations, Steps	emr-cluster-provider.ts create()
per-instance-group Configurations	emr-cluster-provider.ts toInstanceGroupConfig
per-fleet InstanceTypeConfigs	emr-cluster-provider.ts toInstanceFleetConfig
standalone group Configurations	emr-instance-group-config-provider.ts create()
standalone fleet InstanceTypeConfigs	emr-instance-fleet-config-provider.ts create() + ModifyInstanceFleet update

No inverse is needed: Configurations / Steps / InstanceTypeConfigs are all
declared in EMRClusterProvider.getDriftUnknownPaths, and neither instance
provider implements readCurrentState. Non-object / non-array input passes
through untouched so an unresolved intrinsic surfaces as AWS's own validation
error rather than a confusing local crash.

Test plan

• vp run check / typecheck:test / build / test — 516 files, 8704 tests, 0 type errors.
• Revert probe: restoring the raw casts in all three real providers makes
  the four provider-level tests fail; restoring turns them green.
• Real AWS, emr-cluster (2026-08-09): fixture gains top-level +
  nested Configurations, a per-master-group Configurations block and a
  step with StepProperties; verify.sh reads all four back from AWS. All
  green, destroy 12 deleted / 0 errors / 0 orphans.
• Real AWS, emr-instance-configs (2026-08-09): Configurations on the
  standalone TASK group — a conversion site the cluster fixture cannot reach.
  Assertion green.

Both runs are recorded in docs/_generated/integ-last-run.tsv.

Notes

aws emr list-instance-groups turned out to be an AWS-CLI-customized
command that hangs / dies with [Errno 22] in a non-interactive shell
(--no-paginate --no-cli-pager </dev/null does not help), which is why both
fixtures read instance groups through a small node + @aws-sdk/client-emr
helper instead. The trap is recorded as a memory rule.

Deferred

No real-AWS coverage for any InstanceTypeConfigs (instance-FLEET) path —
both EMR fixtures are instance-GROUP based, so the per-fleet conversion sites
and the ModifyInstanceFleet update path are unit-tested only. A single EMR
cluster's instance-collection type is fixed at create (groups XOR fleets), so
covering fleets needs a SECOND fixture + a second cluster per run rather than
an extension of an existing one — filed as (#1400) rather than bundled here.
The existing emr-instance-configs header already recorded this limitation
for #1070; #1383 widens what it hides, which is why it is now tracked.

The AWS::EMR::* types are still absent from NESTED_KEY_TARGETS
(scripts/gen-nested-key-coverage.ts), so this key class is not yet
CI-blocking for EMR. Critic target expansion is tracked in (#1393); adding a
target needs a schema-fixture re-capture and may surface unrelated
divergences, so it does not belong in this bug fix. Recorded in the new
.claude/rules/code-layout.md entry as well.

Closes #1383

[github-actions]

🎉 This PR is included in version 0.278.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀