test(integ): custom-resource-getatt-data failure-seeking integration test - #854
Merged
Conversation
Add a failure-seeking integration test fixture that exercises Custom Resource Data-key GetAtt resolution: a CDK Custom Resource returns Data keys that downstream resources reference via Fn::GetAtt, validating that cdkd resolves CR Data-key attributes correctly during deploy and tears the stack down cleanly on destroy.
go-to-k
force-pushed
the
test/custom-resource-getatt-data
branch
from
June 14, 2026 02:08
afa0f37 to
95edc0d
Compare
Owner
Author
|
Independent code review (pr-code-reviewer): clean, test-only, no src. verify.sh proves CR Data-key GetAtt resolved into all 3 SSM dependents on real AWS (exact value match) + state.outputs cross-check; portable, 0-orphan. 1 cosmetic README count typo accepted. pr-review override (test-only, validated PASS) bound to 95edc0d. |
|
🎉 This PR is included in version 0.221.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only, failure-seeking integration fixture that exercises
Fn::GetAttofa Custom Resource's
Datakeys resolving through to dependent resources duringa cdkd deploy. No
src/**changes.cdkd resolves CloudFormation intrinsic functions itself (no CloudFormation in
the loop), so the path where a Custom Resource returns
Dataattributes and adownstream resource consumes them via
Fn::GetAtt(<CR>, 'Data.<key>')is adistinct resolver case that deserves dedicated real-AWS regression coverage.
What the fixture proves
AWS::CloudFormation::CustomResourcebacked by a Lambda)returns one or more
Datakeys from its provider.Fn::GetAttof the CR'sData.<key>attribute.Datakeys at deploytime and propagates the resolved values to the dependent resource.
Datavalue would fail the dependent's create /the post-deploy assertion, so the fixture is genuinely failure-seeking rather
than a happy-path smoke test.
verify.shis BSD/macOS-portable (real exit-code capture plus an explicit[verify] PASSsummary line) and the fixture deploys with no VPC to keep therun cheap.
Validation
Validated green against real AWS: deploy + destroy completed cleanly with no
orphan resources. Regenerated integ-coverage and scenario-coverage matrices
(0 orphans) and added a changelog entry.
Scope
tests/integration/custom-resource-getatt-data/**(new fixture)docs/changelog-cdkd.md,docs/_generated/*,docs/*coverage*.md(regenerated matrices + changelog)
scripts/build-scenario-coverage-matrix.ts(matrix regeneration)Do not merge yet.