feat: Support hiding tasks with a future start date#2284
feat: Support hiding tasks with a future start date#2284AlD wants to merge 1 commit intogo-vikunja:mainfrom
Conversation
|
Would love to have this implemented, I too am longing for more cleaner overviews and not having all the future tasks in my overview |
kolaente
left a comment
There was a problem hiding this comment.
Hey thanks for the PR!
There are a few things that need changing, see my comments below.
| const rawTasks = await taskStore.loadTasks(params, projectId) | ||
| if (props.hideFuture && showAll.value) { | ||
| const now = new Date() | ||
| tasks.value = rawTasks.filter(t => { |
There was a problem hiding this comment.
Filtering should happen with a date query in the api, not on the client
There was a problem hiding this comment.
I agree, and that's where I initially implemented this, but I immediately ran into unintended side-effects caused by filter_include_nulls applying to all queried fields.
I'd be happy to implement some sort of per-field NULL expression handling, but would like to make sure that this is a direction you'd agree with.
There was a problem hiding this comment.
Yes, proper null filtering would be the way to solve this. This is a feature that I'd like to build eventually, happy to merge a PR if you want to have a go at it.
Allows hiding tasks that have a future start date.
e.g. discussed here: https://community.vikunja.io/t/hide-tasks-where-start-date-is-in-future/588