feat: include subproject tasks (rebase of #2272)

[mds08011]

This PR revives @JamesBatten's work from #2272 so it is ready for merge. My changes are rebasing against main, resolving conflicts, and fixing linter errors. Supersedes and closes #2272 .

[github-actions]

Preview Deployment

Preview deployments for this PR are available at:

URL	Tag	Commit
https://pr-2939.preview.vikunja.dev	ghcr.io/go-vikunja/vikunja:pr-2939	latest
https://sha-5edc7b5160fc573be25a2611754e324ad1291c0f.preview.vikunja.dev	ghcr.io/go-vikunja/vikunja:sha-5edc7b5160fc573be25a2611754e324ad1291c0f	5edc7b5

The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the pr-2939 image — the preview picks up the new version on restart. The per-commit URLs point to a specific version and will not change.

Run locally with Docker

docker pull ghcr.io/go-vikunja/vikunja:pr-2939
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-2939

Last updated for commit 5edc7b5

[kolaente]

auggie review

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[kolaente]

Please take a look at the failing ci.

[kolaente]

Thanks for taking the effort to rebase this! Does that mean you're also taking over the PR?

[mds08011]

Thanks for taking the effort to rebase this! Does that mean you're also taking over the PR?

Hey @kolaente and @JamesBatten, the UI and syntax fixes are done, so the CI should pass. The database changes are going to stretch my abilities, but I'll dive into moving the variable to the Task Collection this weekend to give it a try.

[kolaente]

Unfortunatly, CI is failing again.

Happy to assist on the DB changes.

[Mushkrem]

I tried building this PR myself two days ago, and after removing the duplicate line the project was built correctly, but the buttons ,,Include subprojects" were turning off milliseconds after interacting with them.

I have no knowledge of this codebase, so I tried stitching together whatever seemed to match, but there seemed to be many inconsistencies, namely in files:

• frontend/src/modelTypes/ISavedFilter.ts (line 35) - the IFilters interface (which seems to be meant for exactly this kind of per-view filter data) has no include_subprojects field at all.
• frontend/src/models/projectView.ts (line 18) - sets a default includeSubprojects = false at the top level instead of inside the nested filter object.
• pkg/models/project_view.go (line 163) - Filter *TaskCollection seems to be the only place IncludeSubprojects is actually reachable from a view (Filter.IncludeSubprojects), but there's no top-level IncludeSubprojects field on ProjectView.
• pkg/models/task_collection.go (line 35) - IncludeSubprojects is declared here as a nested field, which doesn't match how the frontend components are reading/writing it.
• frontend/src/components/project/views/ProjectGantt.vue, FilterPopup.vue, ProjectTable.vue, ProjectList.vue, ProjectKanban.vue, ViewEditForm.vue - all read/write includeSubprojects as a top-level property instead of nested under filter.

Given all other toggleable filters append a ?query=value to the URL and this one didn't, I assumed this was supposed to be handled client-side rather than persisted to the DB, so I moved the whole thing over to work that way instead (as is shown above), but that didn't work either and it just stopped doing anything whatsoever, but buttons did persist (didn't turn off)

I have no idea what the "correct" intended design is here (persisted view setting vs. client-side query param), and honestly at this point looking at the PR, I'm not sure the PR itself has settled on one either.

[mds08011]

Thanks for taking the time to build and test this! The intended design (per Kolaente's request) is a persisted view setting that lives inside the Task Collection filter. I pushed a revision so that the view components now correctly read and write the nested filter.include_subprojects. It seems to be building cleanly now, and I included a gif below testing it out.

View with filter setting

Setting

Toggle in action

[mds08011]

Small follow-up: moved the duplicated updateIncludeSubprojects into the project store, and changed the Gantt view to show the source project as a muted label on the bar like list/kanban do.

[HarshPatel5940]

damnm, i was looking for this feature.

did we ensure that members of parent project can see tasks of child projects and its own, while child project members can only see their own

[mds08011]

did we ensure that members of parent project can see tasks of child projects and its own, while child project members can only see their own

Yes this is the case. I added a test to check it as well.

[dodzod]

Hi - just bumping this in case anyone has time to finalise it - it looks like the only required test failure is "file is not properly formatted" which hopefully should be an easy fix, in fact it looks like it is just a surplus blank line. Sadly I don't have the practical development skills to add a commit, run the tests etc. or I would do so.