feat(attachments): preview video attachments in a modal 🤖🤖🤖 - #3491
Open
AlexDeus20 wants to merge 1 commit into
Open
feat(attachments): preview video attachments in a modal 🤖🤖🤖#3491AlexDeus20 wants to merge 1 commit into
AlexDeus20 wants to merge 1 commit into
Conversation
Video attachments currently download on click. Play them inline in a modal with native controls instead, mirroring the existing image and PDF attachment previews. Adds canPreviewVideo (mime-gated, like the image and PDF helpers) and a video modal to the attachments list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
area/attachments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3490.
What
Video attachments (mp4/webm/ogg/mov/m4v) currently download on click. This plays them inline in a modal with native controls instead, mirroring the existing image and PDF attachment previews.
How
canPreviewVideo(attachment)inmodels/attachment.ts— mime-gated (video/*) with an extension allow-list, matching the existingcanPreviewImage/canPreviewPdfhelpers; folded intocanPreview.Attachments.vue—viewOrDownloadroutes video attachments to a new<Modal :wide><video controls></Modal>(same shape as the PDF modal). No autoplay.No API/backend changes — authenticated blob loading already exists via
AbstractService.getBlobUrl. Fully downloaded blob (like images/PDFs today), so no streaming.Testing
pnpm lint/pnpm lint:stylespass;vite buildpasses.Notes
Implemented with the help of Claude Code (AI); I reviewed the code and runtime-tested the result.