Fix cmg bug where type aliases are replaced by their underlying types#540
Merged
Fix cmg bug where type aliases are replaced by their underlying types#540
cmg bug where type aliases are replaced by their underlying types#540Conversation
Member
douglaswth
commented
Mar 20, 2025
- The initial effort to support type aliases was pulling the underlying type of type aliases when generating type names and zero values, but that was not the correct behavior. This fix changes it so type aliases are treated the same way as named types.
- The initial effort to support type aliases was pulling the underlying type of type aliases when generating type names and zero values, but that was not the correct behavior. This fix changes it so type aliases are treated the same way as named types.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 85.34% 85.45% +0.10%
==========================================
Files 39 39
Lines 2211 2227 +16
==========================================
+ Hits 1887 1903 +16
Misses 298 298
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.