Skip to content

Fix cmg bug where type aliases are replaced by their underlying types#540

Merged
raphael merged 1 commit intomainfrom
fix-cmg-struct-alias-bug
Mar 20, 2025
Merged

Fix cmg bug where type aliases are replaced by their underlying types#540
raphael merged 1 commit intomainfrom
fix-cmg-struct-alias-bug

Conversation

@douglaswth
Copy link
Copy Markdown
Member

  • The initial effort to support type aliases was pulling the underlying type of type aliases when generating type names and zero values, but that was not the correct behavior. This fix changes it so type aliases are treated the same way as named types.

- The initial effort to support type aliases was pulling the underlying
  type of type aliases when generating type names and zero values, but
  that was not the correct behavior. This fix changes it so type aliases
  are treated the same way as named types.
@douglaswth douglaswth requested a review from raphael March 20, 2025 20:12
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (7757c8b) to head (96aff9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   85.34%   85.45%   +0.10%     
==========================================
  Files          39       39              
  Lines        2211     2227      +16     
==========================================
+ Hits         1887     1903      +16     
  Misses        298      298              
  Partials       26       26              
Flag Coverage Δ
micro 85.45% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raphael
Copy link
Copy Markdown
Member

raphael commented Mar 20, 2025

Looks great, thank you!

@raphael raphael merged commit 3966997 into main Mar 20, 2025
6 checks passed
@raphael raphael deleted the fix-cmg-struct-alias-bug branch March 20, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants