Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 85.45% 85.25% -0.20%
==========================================
Files 39 39
Lines 2227 2232 +5
==========================================
Hits 1903 1903
- Misses 298 303 +5
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
douglaswth
added a commit
that referenced
this pull request
Apr 30, 2025
- #545 inadvertently introduced a bug where a call to `os.Remove` on a temporary file that should have been moved would have been allowed to fail started becoming logged as an error. - This fixes the issue by making sure that the error returned by `os.Remove` is not `fs.ErrNotExist` which is an acceptable error in this case.
douglaswth
added a commit
that referenced
this pull request
Apr 30, 2025
- #545 inadvertently introduced a bug where a call to `os.Remove` on a temporary file that should have been moved would have been allowed to fail started becoming logged as an error. - This fixes the issue by making sure that the error returned by `os.Remove` is not `fs.ErrNotExist` which is an acceptable error in this case.
raphael
pushed a commit
that referenced
this pull request
May 1, 2025
- #545 inadvertently introduced a bug where a call to `os.Remove` on a temporary file that should have been moved would have been allowed to fail started becoming logged as an error. - This fixes the issue by making sure that the error returned by `os.Remove` is not `fs.ErrNotExist` which is an acceptable error in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.