Change cmg -testify flag to use assert.TestingT#639
Merged
douglaswth merged 1 commit intomainfrom Jan 26, 2026
Merged
Conversation
When the -testify flag is used, mock constructors now accept assert.TestingT instead of *testing.T, providing better flexibility for testing with custom test harnesses. Also update the minimum Go version requirement from 1.21 to 1.24 in GitHub Actions workflows and README.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
+ Coverage 86.94% 86.95% +0.01%
==========================================
Files 39 39
Lines 2007 2009 +2
==========================================
+ Hits 1745 1747 +2
Misses 238 238
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xeger
approved these changes
Jan 23, 2026
| {{ if .Alias }}{{ .Alias }} {{ end }}"{{ .PkgPath }}" | ||
| {{- end }} | ||
| {{ range .ExtImports }} | ||
| {{- if and (gt (len .StdImports) 0) (or (gt (len .ExtImports) 0) (gt (len .IntImports) 0)) }} |
Contributor
There was a problem hiding this comment.
Oof. I am so not a fan of go templates!
I don't mind lisp. But lisp in go is ponderous!
raphael
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the -testify flag is used, mock constructors now accept assert.TestingT instead of *testing.T, providing better flexibility for testing with custom test harnesses.
Also update the minimum Go version requirement from 1.21 to 1.24 in GitHub Actions workflows and README.