Merged
Conversation
Build the service resource without setting a schema URL so it can merge cleanly with the SDK default resource.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 86.95% 86.95% -0.01%
==========================================
Files 39 39
Lines 2009 2008 -1
==========================================
- Hits 1747 1746 -1
Misses 238 238
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clue.NewConfigby usingresource.NewSchemaless.Rationale
resource.Default()(from the OTel SDK) and clue's service resource were using different schema URLs, which can cause the SDK to fail fast with a conflicting schema URL error duringresource.Merge. Building the service resource schemaless avoids schema conflicts while keeping the semantic attributes.Test plan
go test ./...