refactor(model): centralize early stream termination classification#184
Merged
Conversation
Move the empty-vs-truncated classification of streams that close before message stop into model.NewStreamEndedEarlyError, deleting the duplicated streamEndedEarlyError helpers in the Bedrock and Anthropic adapters. The model package owns the stream integrity error contract; adapters now only report the provider, operation, and whether a message had started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.NewStreamEndedEarlyError(provider, operation, started)as the single classifier for streams that close cleanly before message stop: never-started streams yield the retryable empty-stream error (errors.Is(err, model.ErrEmptyStream)), mid-message closes yield the retryabletruncated_streamprovider error without the sentinel.streamEndedEarlyErrorhelpers from the Bedrock and Anthropic adapters; both now call the model constructor. Error kinds, codes, and messages are unchanged.Test plan
go test ./...make lint