Revise config path check #1790
Merged
Revise config path check #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tries to handle checking UserPath= override now. This is cursed because it doesn't technically require quotes in the path if it has spaces. I hope we never have to handle multiple args here. - Searches specifically for the game config path otherwise, as FirstOrDefault was defaulting to the first path it could find in the directory if there wasn't a match by length. I've intentionally left in some comments and hopefully impossible code path in the try/catch. This is so it's easier to test if you change the default search path without using the UserPath override. It can be removed if that's a merge blocker.
goaaats
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've intentionally left in some comments and hopefully impossible code path in the try/catch. This is so it's easier to test if you change the default search path without using the UserPath override. It can be removed if that's a merge blocker.