Fix Remote Patcher failure on Finish #1802
Conversation
|
This will cause the patcher to fail on windows from what has been talked about in the discord. |
|
I don't have a Windows install to test with right now - will see if I can get one together to make sure it works on both |
sjenkins7
force-pushed
the
fix-patcher-failure-on-finish
branch
from
5034ec9 to
65f1d1b
Compare
|
Was able to reproduce it on both at the end of patching Did a clean setup on both Windows & Linux. I don't have the space right now to do a full re-download on both a Windows VM & Linux, but seeing it pass the Tested on Windows by building an MSI with the same workflow as in https://github.com/goatcorp/FFXIVQuickLauncher/blob/master/.github/workflows/ci-workflow.yml Doing one last test, by restoring my Linux install to a snapshot before today's HF, but I believe this is good to go if someone wants to sanity check on their side too EDIT: clarification |
Windows installer implicitly triggers ToString Linux does not - causing failure
sjenkins7
force-pushed
the
fix-patcher-failure-on-finish
branch
from
65f1d1b to
b38a40c
Compare
|
Also patched up from before the HF to current on Linux without issue |
4 participants
This corrects the casting for the Remote Patch Installer on Finish, which triggers failures in Core.
See: goatcorp/XIVLauncher.Core#287 (comment) for context
Tested on Linux via Flatpak