Update SDL and ImGui to newer versions

[wolfcomp]

Things changing in this:
.NET 8 -> .NET 9
Serilog 2 -> Serlog 4
ImGui.NET -> Hexa.NET.ImGui
Veldrid -> Hexa.NET.SDL3

.NET update reason:
Pulling in newest XIVLauncher.Common for future additions.

Serilog update reason:
.NET 9 doesn't allow for Serilog 2.

ImGui update reason:
Need better bindings for SDL3.

SDL update reason:
Veldrid is abandoned.

Build pipeline will fail due to the .NET build only having SDK 8.0.x and not SDK 9.0.x

[wolfcomp]

I have not checked all draws for assert errors, but on a first pass it looks fine.

Some of the coloring seems to have changed slightly when it comes to the background draw, but not sure if it might be related to the new styling options that is in the new ImGui version.

Build will fail to complete until https://github.com/goatcorp/XIVLauncher.Core/blob/main/.github/workflows/build.yml#L28-L31 allows for .NET 9 builds which both .NET 8 and 9 comes pre-installed with the Linux runner

[Blooym]

Requesting goat's review for this one since to my knowledge prior work with HexaImGui was done in Dalamud (and I'm not all-to-knowledgable on the specifics). From a first glance though all this looks fine to me

[rankynbass]

Builds but does not run on bazzite/fedora43. When launched from terminal:

ERROR: vkQueuePresentKHR VK_ERROR_SURFACE_LOST_KHR
wp_linux_drm_syncobj_surface_v1#90: error 1: Surface got destroyed already
ERROR: Wayland display connection closed by server (fatal)
ERROR: This surface does not support presenting!

Tried with SDL_VIDEODRIVER=x11, and I get:

ERROR: Present mode not supported!
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  146 ()
  Minor opcode of failed request:  5
  Resource id in failed request:  0x2c0002e
  Serial number of failed request:  1024
  Current serial number in output stream:  1026

[rankynbass]

As of d4cdb5d (fix id assert error), it launches and all the settings tabs work. Still some graphical issues, but the window pops up, and then it successfully launches the game.

[wolfcomp]

As of d4cdb5d (fix id assert error), it launches and all the settings tabs work. Still some graphical issues, but the window pops up, and then it successfully launches the game.

new hash 03d2a5a due to rebase

[wolfcomp]

X11 seems to not report scaling correctly (could just be xwayland) so may need to add a scaling override setting if this becomes a problem. Default launches with video driver "wayland" unless explicitly set otherwise.

Everything else works as the old XLCore did, just with newer ImGui version and better bindings

[rankynbass]

Can confirm, aside from slightly wonky X11 scaling when in KDE wayland with "Apps scale themselves", it's working. There may be some edge cases we havent hit yet, but I was able to use all the settings tabs, change settings, save settings. One time password works as well.

We need to have a steam deck user do some testing to see how it functions in that environment, though. Need to make sure they can still interact with it, enter info, etc.

[Blooym]

I’ll do device testing for steam deck and another set of tests for regular desktop setups as soon as I’m available to do so

[keysmashes]

seems like it works for me (X11). however, the cursor (in at least the username/password boxes) is very thin and also red, so it's really hard to see.

also, this manages to induce really bad coil whine somewhere in my computer, which nothing else has done with this computer ever?? the pitch modulates with window size and changes on different settings tabs, and doesn't reproduce with a screenshot. no idea at all

[Blooym]

also, this manages to induce really bad coil whine somewhere in my computer, which nothing else has done with this computer ever?? the pitch modulates with window size and changes on different settings tabs, and doesn't reproduce with a screenshot. no idea at all

Sounds like the frame rate isn’t being capped properly for the launcher UI and thus overworking the GPU?

[rankynbass]

I just checked with mangohud (mangohud --dlsym ./XIVLauncher.Core) and it was running at >6500 fps. So definitely need to cap frame rate. We can probably just set Vsync on.

[rankynbass]

Something with the WINE tab in particular seems to be dropping performance significantly on the new build - especially when scrolling or using the dropdowns. Every other tab seems to perform fine, though.

Not a blocker but definitely something to note

I'm not seeing anything when I run it. No spike in cpu or gpu usage (btop, nvtop). With and without gamemode installed and active/inactive. Could be just because I have a very fast cpu and gpu, though.

[Blooym]

Marking as changes needed since this currently instantly crashes on the Steamdeck with my testing. I'll take a look as to what's causing it

[Blooym]

User testing reports:

• Pasting text may freeze the launcher on Nvidia with Wayland (non-blocker)
• Process will not exit properly when the game closes meaning users have to kill it manually (blocker)
• Crashes instantly on steam deck (blocker)

[Zyian]

New ImGui updates also cause debug errors, hovering over the duplicate news entries

[rankynbass]

The submodule is currently broken. Seems to work with latest master (commit 8547d31), or tag 7.0.20 as used by xlcore 1.3.0. It appears the "fix some platform compile issues" commit (f5fe732) actually prevents the submodule from detecting linux.

[wolfcomp]

The submodule is currently broken.

This sounds like you are compiling it wrong in as it specifically uses the RIDs that needs to be provided for a compile to work