web: Indicate when caps-lock is active during password input. #12733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GirlBossRush
force-pushed
the
51-caps-lock-indicator
branch
from
2588d77 to
3d7a451
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12733 +/- ##
==========================================
+ Coverage 92.68% 92.76% +0.08%
==========================================
Files 785 785
Lines 39623 39623
==========================================
+ Hits 36724 36757 +33
+ Misses 2899 2866 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GirlBossRush
force-pushed
the
51-caps-lock-indicator
branch
from
3d7a451 to
753827f
Compare
GirlBossRush
force-pushed
the
51-caps-lock-indicator
branch
2 times, most recently
from
4c6f199 to
ae9b6ca
Compare
Determining the state of the caps-lock key can be tricky as we're dependant on a user-provided input to set a value. Thus, our initial state defaults to not display any warning until the first keystroke. - Revise to better use lit-html.
GirlBossRush
force-pushed
the
51-caps-lock-indicator
branch
from
ae9b6ca to
be69786
Compare
GirlBossRush
added
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Hey team! 👋
I had fun implementing the caps-lock detection feature! Since we rely on keystroke events to determine the caps-lock state, the warning stays hidden until we get that first user input.
This is my first time contributing to the lit-html parts of our codebase, and I'm excited to get your thoughts. I was able to bring the
InputPasswordcomponent up to speed with some of authentik's more recent component design patterns, such as leaning on the Lit's ref directive to manage event listeners.I'd love feedback on my approach to both the LitHTML patterns and authentik's existing conventions.
Looking forward to your review!
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)