web: Normalize client-side error handling #13595
Conversation
GirlBossRush
added
enhancement
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13595 +/- ##
==========================================
- Coverage 92.78% 92.73% -0.06%
==========================================
Files 796 796
Lines 40750 40750
==========================================
- Hits 37809 37788 -21
- Misses 2941 2962 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-6a70e7e719339b7b70e7c9b8590e382d6e3492af
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-6a70e7e719339b7b70e7c9b8590e382d6e3492afAfterwards, run the upgrade commands from the latest release notes. |
rissson
changed the title
| renderEmpty(): TemplateResult { | ||
| renderEmpty(inner?: SlottedTemplateResult): TemplateResult { | ||
| if (this.error) { | ||
| return super.renderEmpty(inner); | ||
| } | ||
|
|
There was a problem hiding this comment.
Fixes issue where errors don't render when the empty state is active. IMO this needs fixing in the base Table class but that refactor will need a PR of its own.
GirlBossRush
force-pushed
the
error-normalizing
branch
from
a00fd5a to
ee0405e
Compare
- Add clearer reporting for API and network errors. - Tidy error checking. - Partial type safety for events.
GirlBossRush
force-pushed
the
error-normalizing
branch
from
7a97b21 to
6a70e7e
Compare
Details
This PR is a preparation for permissions based UI rendering.
The focus of this PR is the parsing of runtime errors into type-safe interfaces. By default TypeScript will leave Promise
.catch's error parameter asanyto indicate that the error may arise from unexpected sources, such as network issues, runtime type errors, etc.The changes in this PR seek to both enforce better typing and provide more accurate runtime information.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)