(BEDS-875) Add rewards chart history based on premium perks#1220
Merged
enzo-bitfly merged 8 commits intostagingfrom Sep 2, 2025
Merged
(BEDS-875) Add rewards chart history based on premium perks#1220enzo-bitfly merged 8 commits intostagingfrom
enzo-bitfly merged 8 commits intostagingfrom
Conversation
remoterami
force-pushed
the
BEDS-875/rewards-chart
branch
from
517ce8d to
c6d5fa4
Compare
Deploying beaconchain with
|
| Latest commit: |
3e7b8de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa802bc2.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-875-rewards-chart.beaconchain.pages.dev |
LuccaBitfly
requested changes
Dec 19, 2024
sasha-bitfly
approved these changes
Dec 19, 2024
Contributor
|
@remoterami Ideally to cover the changes with tests. Unit tests are nice, but api tests can be fine. |
remoterami
force-pushed
the
BEDS-875/rewards-chart
branch
from
8e79801 to
362046d
Compare
Contributor
Author
I've added some tests and did some refactoring. Could probably further solidify and generalize the testing setup, but that depends on our coverage goals and I didn't want to over-engineer for now. Open to suggestions though |
sasha-bitfly
approved these changes
Jan 2, 2025
remoterami
force-pushed
the
BEDS-875/rewards-chart
branch
from
2ca36e5 to
252b8a8
Compare
remoterami
force-pushed
the
BEDS-875/rewards-chart
branch
from
252b8a8 to
c8c0a79
Compare
LuccaBitfly
force-pushed
the
BEDS-875/rewards-chart
branch
from
c8c0a79 to
3821521
Compare
Contributor
|
rebased with staging |
LuccaBitfly
force-pushed
the
BEDS-875/rewards-chart
branch
4 times, most recently
from
0a3e329 to
1e90339
Compare
LuccaBitfly
force-pushed
the
BEDS-875/rewards-chart
branch
2 times, most recently
from
a106557 to
05b3fce
Compare
remoterami
commented
Jul 8, 2025
Contributor
Author
remoterami
left a comment
remoterami
left a comment
There was a problem hiding this comment.
very nice refactoring, looks way better now. ptal, left some comments
invis-bitfly
previously requested changes
Jul 8, 2025
invis-bitfly
reviewed
Jul 8, 2025
LuccaBitfly
force-pushed
the
BEDS-875/rewards-chart
branch
2 times, most recently
from
53db867 to
886de83
Compare
Contributor
Author
same, lgtm |
enzo-bitfly
force-pushed
the
BEDS-875/rewards-chart
branch
from
886de83 to
1525e0f
Compare
enzo-bitfly
force-pushed
the
BEDS-875/rewards-chart
branch
from
ce1cc03 to
1efe601
Compare
…instead of `dashboard overview` store `chart history seconds` is part of the `user` and `dashboard overview` data, but `rewards_history_seconds` is only part of `user` data See: BEDS-875
- prevent showing `aggregation` filter in `summary` chart to match `rewards chart` - fix aggregation filter for logged-out usrers in `summary chart` See: BEDS-875
enzo-bitfly
force-pushed
the
BEDS-875/rewards-chart
branch
from
3be1f06 to
3e7b8de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.