You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
also includes a switch to a more sane env lib so i dont have to define everything 45 times
first commit might not build, need to remove all the now useless casting everywhere
invalid host as primary, valid host as fallback: connection succeeds after a small delay (~8s)
valid host as primary, invalid host as fallback: connection succeeds instantly, no attempt made to invalid host
should note that the logic only gets applied when a new connection gets opened. this means that a faulty host that accepts/holds connections but fails to execute any queries will continue to cause issues until the faulty host gets stopped/fixed.
a potential fix is setting the max connection lifetime to something low (5m?) and adding a custom dial function that does a sanity check each time to confirm that the host is safe to use. sounds annoying tho as you would only have the raw dial to do that.
at some point it makes more sense to just write our own wrapper tho which would allow for much more flexibility.
also this pr is breaking as it makes the ssl flag configurable instead of always forcing ssl with clickhouse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also includes a switch to a more sane env lib so i dont have to define everything 45 times
first commit might not build, need to remove all the now useless casting everywhere