Skip to content

(BEDS-1100) API: Incorporate dashboard archival status into notification endpoints#1233

Merged
remoterami merged 4 commits intostagingfrom
BEDS-1100/api-notifications-middleware-filter-archived
Jan 9, 2025
Merged

(BEDS-1100) API: Incorporate dashboard archival status into notification endpoints#1233
remoterami merged 4 commits intostagingfrom
BEDS-1100/api-notifications-middleware-filter-archived

Conversation

@remoterami
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12864ad
Status: ✅  Deploy successful!
Preview URL: https://72bff15c.beaconchain.pages.dev
Branch Preview URL: https://beds-1100-api-notifications.beaconchain.pages.dev

View logs

@remoterami remoterami changed the title (BEDS-1100) API: add vdb archived check to notifications middleware (BEDS-1100) API: Incorporate dashboard archival status into notification endpoints Jan 6, 2025
@LuccaBitfly
Copy link
Contributor

LuccaBitfly commented Jan 7, 2025

Also if you're not adding integration tests now, pls create medium prio ticket for adding them.

@remoterami
Copy link
Contributor Author

Also if you're not adding integration tests now, pls create medium prio ticket for adding them.

I think that should be covered by 579 already

Copy link
Contributor

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@remoterami remoterami merged commit a1d5ae3 into staging Jan 9, 2025
4 checks passed
@remoterami remoterami deleted the BEDS-1100/api-notifications-middleware-filter-archived branch January 9, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants