Merged
Conversation
Contributor
LuccaBitfly
commented
Jan 13, 2025
LuccaBitfly
commented
- refactor: generalize util slice dedupe
- fix: show correct exchange rates for gnosis
LuccaBitfly
force-pushed
the
BEDS-1124/prices
branch
from
b8a8872 to
f48e30e
Compare
remoterami
suggested changes
Jan 13, 2025
Contributor
remoterami
left a comment
remoterami
left a comment
There was a problem hiding this comment.
prices more accurate than Binance 👍 Some minor comments, ptal
LuccaBitfly
force-pushed
the
BEDS-1124/prices
branch
2 times, most recently
from
73a1164 to
e5499c1
Compare
remoterami
approved these changes
Jan 14, 2025
Contributor
There was a problem hiding this comment.
lgtm!
Unrelated to your changes, but in addPricePairs (which you merged) I think that pricesCopy doesn't really do anything (bcus maps are ref types in go, can't create a deep copy like that). If you agree you could clean that up, but shouldn't cause any harm if not. See https://github.com/gobitfly/beaconchain/pull/1258/files#diff-b341d664d42e9927a41a4d294042b57ffd5461d62357ed14e6022352b5f840b0R158
See: BEDS-1124
LuccaBitfly
force-pushed
the
BEDS-1124/prices
branch
from
e5499c1 to
06cb501
Compare
See: BEDS-1124
LuccaBitfly
force-pushed
the
BEDS-1124/prices
branch
from
c5c91f6 to
311fe90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.