refactor: revise and add tests for exporter/modules/genesis_deposit.go#1354
Merged
Monika-Bitfly merged 30 commits intostagingfrom Apr 1, 2025
Merged
refactor: revise and add tests for exporter/modules/genesis_deposit.go#1354Monika-Bitfly merged 30 commits intostagingfrom
exporter/modules/genesis_deposit.go#1354Monika-Bitfly merged 30 commits intostagingfrom
Conversation
Tangui-Bitfly
suggested changes
Feb 26, 2025
Contributor
Tangui-Bitfly
left a comment
Tangui-Bitfly
left a comment
There was a problem hiding this comment.
Your tests are taking too long to execute
ok github.com/gobitfly/beaconchain/pkg/exporter/modules 71.193s coverage: 0.7% of statements
It should not be over, let say, 5s (and it's very generous)
Tangui-Bitfly
approved these changes
Mar 4, 2025
invis-bitfly
force-pushed
the
m/refactor-genesis-deposit
branch
from
5a2a82f to
6ff7b60
Compare
Deploying beaconchain with
|
| Latest commit: |
6ff7b60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f002c5c6.beaconchain.pages.dev |
| Branch Preview URL: | https://m-refactor-genesis-deposit.beaconchain.pages.dev |
invis-bitfly
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.