DF-97/add section stacking hub#1732
Conversation
marcel-bitfly
changed the title
| const playVideo = async () => { | ||
| if (videoRef.value) { | ||
| try { | ||
| await videoRef.value.play() |
There was a problem hiding this comment.
question: plz check if there is the following issue for ios Safari: autoplayed videos sometimes tend to be full-size and make the page hard to use (esp. if there a several autoplayed videos)
There was a problem hiding this comment.
There is a potential issue in iOS safari where video might not play at all when entering viewport. I would need Tanya to test this. If the issue is confirmed then I need to implement an alternative approach with animated frames.
There was a problem hiding this comment.
if the video is not playing, we should be aware of it, but it is not a problem for now...the real issue would be the auto fullscreen
| } | ||
|
|
||
| // Intersection Observer - play once when entering viewport | ||
| const { stop: stopIntersectionObserver } = useIntersectionObserver( |
There was a problem hiding this comment.
nitpick: can you think about wrapping this third party code (vueuse) into its own composable?
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Outdated
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Outdated
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Outdated
Show resolved
Hide resolved
| title-icon="file-code" | ||
| :title="$t('products.landing_page.staking_hub.cards.staking_mobile_app.title')" | ||
| class="min-h-[495px] relative overflow-hidden" | ||
| tabindex="0" |
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Outdated
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Show resolved
Hide resolved
| <img | ||
| src="/assets-2usdf/img/app-store-btn.svg" | ||
| alt="Download on App Store" | ||
| class="w-auto h-[41px]" |
There was a problem hiding this comment.
thought: things should only be changed by width and sometimes aspect-ratio and almost never with height
There was a problem hiding this comment.
In this case it is more straight-forward to use height in order to ensure exact compatibility with design.
frontend/layers/products/app/components/ProductLandingpageSectionStakinghub.vue
Outdated
Show resolved
Hide resolved
frontend/layers/products/app/components/ProductLandingpageSectionTestimonials.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
nitpick: maybe a semantic name would be a good idea
marcel-bitfly
left a comment
marcel-bitfly
left a comment
There was a problem hiding this comment.
very good work 💪
(esp. considering that this is your first issue)
I am looking forward to see more of your work
Deploying beaconchain with
|
| Latest commit: |
e2be7f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da6f1d03.beaconchain.pages.dev |
| Branch Preview URL: | https://df-97-add-section-stacking-h.beaconchain.pages.dev |
rucister
force-pushed
the
DF-97/add-section-stacking-hub
branch
from
d06a314 to
412424f
Compare
| variant?: 'branded' | 'primary' | 'secondary', | ||
| } | ||
| // Make `to` and `disabled` mutually exclusive | ||
| & ( |
There was a problem hiding this comment.
question: did you test your implementation? I think this should not be optional (but I could be wrong)
| & ( | |
| & ( | |
| | { disabled: boolean, to?: never } | |
| | { disabled?: never, to: NuxtLinkProps['to'] } | |
| ) |
There was a problem hiding this comment.
also I thought using the generic in script tag would be necessary (it could be that this is obsolete now with a newer version of nuxt/typescript
<script setup lang="ts" generic="WORKAROUND_FOR_CONDITIONAL_PROPS">
also mentioning the link is a good idea as in frontend/layers/base/app/components/BaseCard.vue
// vuejs/core#8952
rucister
force-pushed
the
DF-97/add-section-stacking-hub
branch
from
412424f to
e2be7f8
Compare
marcel-bitfly
force-pushed
the
DF-97/add-section-stacking-hub
branch
from
e2be7f8 to
34e2f05
Compare
2 participants
No description provided.