fix: copying of files to GobView in projects with subdirectories #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
special paths are os and language dependant. ex. <command-line> -> <command line> for macos
Counter for unique file names was broken by skipping directory entries
Closed
michael-schwarz
changed the title
michael-schwarz
requested review from
michael-schwarz
and removed request for
stilscher
michael-schwarz
approved these changes
Sep 23, 2023
|
Thank you for the PR @sallto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the copying of source files to the GobView directory.
The original solution didn't check whether a filesystem entry is a directory which caused the counter (ex. file.5.c) to mismatch on projects with subdirectories.
Additionally fixed the filter for special "files" like
<command-line>. It now skips all entries starting and ending with brackets, since the specific strings (ex. "command-line") differ for languages and OS. (can be split into a separate PR, but I felt that would be too small)