Skip to content

Remove spurious long double constant warning #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

michael-schwarz
Copy link
Member

This removes spurious warnings when analyzing code that contains floating point constants that are larger that OCaml floats. (c.f. goblint/cil#136)

As suggested by @sim642, we assert false in Goblint when we encounter such a value without a string representation - with an exception for the constant zero as it can be represented correctly regardless of type, and CIL generates it for zero-initialized data.

@michael-schwarz michael-schwarz added the cleanup Refactoring, clean-up label Oct 3, 2023
@michael-schwarz michael-schwarz requested a review from sim642 October 4, 2023 10:39
@michael-schwarz michael-schwarz merged commit 475f3bb into master Oct 4, 2023
@michael-schwarz michael-schwarz deleted the long_double_constant_warning branch October 4, 2023 11:51
@sim642 sim642 added this to the v2.3.0 milestone Oct 4, 2023
@michael-schwarz michael-schwarz added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up hacktoberfest-accepted https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants