Nicer SV-COMP result for validator when witness is missing #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
cleanup
Better than "EXCEPTION (Failure)" as verdict.
Better than "EXCEPTION (Failure)" as verdict.
sim642
force-pushed
the
yaml-witness-validate-missing
branch
from
f953b8f to
85ab1fd
Compare
michael-schwarz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our SV-COMP validator returns
ERROR (Failure)whenever the witness file is missing. This is quite ugly because it's very non-informative and could include otherfailwithcases which are indistinguishable.This PR changes the verdict to
ERROR (witness missing)in such cases.It also refactors the passing of YAML witness validation to the SV-COMP result printing to be explicit rather than go through global variables.
TODO