Skip to content

Check overflows when generating witnesses #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-schwarz merged 2 commits into from
Jul 17, 2024
Merged

Check overflows when generating witnesses #1546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14d51d5
Check overflows when generating witnesses
michael-schwarz Jul 12, 2024
06ea5e0
Rm resolved TODO
michael-schwarz Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cdomains/apron/sharedFunctions.apron.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,7 @@ struct
let expr = ref (fst @@ coeff_to_const false (Linexpr1.get_cst linexpr1)) in
let append_summand (c:Coeff.union_5) v =
match V.to_cil_varinfo v with
| Some vinfo ->
(* TODO: What to do with variables that have a type that cannot be stored into ILongLong to avoid overflows? *)
| Some vinfo when IntDomain.Size.is_cast_injective ~from_type:vinfo.vtype ~to_type:(TInt(ILongLong,[])) ->
let var = Cilfacade.mkCast ~e:(Lval(Var vinfo,NoOffset)) ~newt:longlong in
let coeff, flip = coeff_to_const true c in
let prod = BinOp(Mult, coeff, var, longlong) in
Expand All @@ -284,13 +283,14 @@ struct
else
expr := BinOp(PlusA,!expr,prod,longlong)
| None -> M.warn ~category:Analyzer "Invariant Apron: cannot convert to cil var: %s" (Var.to_string v); raise Unsupported_Linexpr1
| _ -> M.warn ~category:Analyzer "Invariant Apron: cannot convert to cil var in overflow preserving manner: %s" (Var.to_string v); raise Unsupported_Linexpr1
in
Linexpr1.iter append_summand linexpr1;
!expr


let lcm_den linexpr1 =
let exception UnsupportedScalar
let exception UnsupportedScalar
in
let frac_of_scalar scalar =
if Scalar.is_infty scalar <> 0 then (* infinity means unbounded *)
Expand Down