Split IntDomains into separate files
#1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds signatures to implementation to fix "contains type variables that cannot be generalized" errors.
Also moved Exclusion from IntDomain0 to DefExcDomain to fix module cycle.
michael-schwarz
approved these changes
Dec 15, 2024
Member
michael-schwarz
left a comment
michael-schwarz
left a comment
There was a problem hiding this comment.
Do we need to wait on anything here, or should we just go ahead and merge before it gets stale?
Adapting other PRs to this is probably easier than recreating this with all the history preservation things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #1575 because
intDomain.mlis the largest file we have.They are moved to a new
intsubdirectory. There's also aIntDomain0with all the various interfaces and their adapters.The splitting is done such that git blame history is preserved for default git settings. Thus the git graph is a bit of a braid.