Make update_offset idempotent for blobs
#1644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sim642
reviewed
Dec 30, 2024
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
sim642
approved these changes
Jan 3, 2025
sim642
added a commit
that referenced
this pull request
Jan 9, 2025
Member
|
Turns out this accidentally fixed a TODO in our regression suite as well: ff0e24c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates #1559 which at the time was only merged into the branch for my thesis.
Otherwise, a publish lead to a Blob value being placed inside a zero-inited Blob, which lead to value Top inside the blob, which caused function calls to be lost.
See #1558 which shows how Goblint without this fix is unsound.