Skip to content

Add bash completion for array element addition and removal #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add bash completion for array element addition and removal #1705

wants to merge 2 commits into from
+17 −8

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Mar 7, 2025

This allows bash completing things like --set witness.yaml.entry-types[+] to offer a list of valid things to add or remove (with [-]) from the list.

michael-schwarz
michael-schwarz reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't have argument completion set up, so I didn't test it. However, it seems like an innocent local thing we should probably just merge.

@sim642 sim642 requested a review from karoliineh April 7, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz left review comments

@karoliineh karoliineh Awaiting requested review from karoliineh

Assignees
No one assigned
Labels
feature usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sim642 @michael-schwarz